Skip to content

Resolve various type errors with New Type Solver - #108

Draft
whoamimaybeme wants to merge 4 commits into
etohgame:devfrom
whoamimaybeme:new-type-checker-fixes-1
Draft

Resolve various type errors with New Type Solver#108
whoamimaybeme wants to merge 4 commits into
etohgame:devfrom
whoamimaybeme:new-type-checker-fixes-1

Conversation

@whoamimaybeme

@whoamimaybeme whoamimaybeme commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This PR should resolve as many type errors within the New Type Checker as possible without forcing the New Type Checker onto the EToH v6 kit. Since the old type checker is leaving soon, it's probably best to get as many of these issues out of the way before it gets forced.

There will be future pull requests that will come after this one is merged that will resolve the rest of the type errors and will potentially cause a few minor changes to how the v6 kit functions.

A few notes

  • None of the current changes proposed are final. This is a draft!
  • I wish to try and reduce how much of the code is changed.
    • Example: I wish to use type casts for Players.LocalPlayer instead of using a bunch of if then statements.
  • I try to use "" and math.nan as replacements for the Utility.Config.Type types. Instances of this include within the MusicZoneEditor and the JumpLauncher.

Current changes

  • Booster
    • Changed some internal types to use generics instead of the TweenConfiguration and TouchConfiguration variables.
  • BoostRemover
    • The configuration template is no longer defined in the .Init function
    • The .Init function has been removed
  • Button
    • The configuration template is no longer defined in the .Init function
    • The .Init function has been removed
    • Small changes to type casts and other.
  • KeyGroup
    • The configuration template is no longer defined in the .Init function
    • The .Init function has been removed
  • Morpher
    • The configuration template is no longer defined in the .Init function
  • MusicZoneEditor
    • The configuration template is no longer defined in the .Init function
    • The .Init function has been removed
  • Sequencer
    • Configuration templates are no longer defined in the .Init function
    • The .Init function has been removed

@whoamimaybeme
whoamimaybeme changed the base branch from main to dev August 13, 2026 16:55
@whoamimaybeme
whoamimaybeme marked this pull request as draft August 14, 2026 14:13
@whoamimaybeme whoamimaybeme changed the title Moving config templates out of .Init functions (New Type Solver #1) Resolve various type errors with New Type Solver Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant